@scott-nag - The PR looks good to me except the changes to install_docker.yml. The changes introduced are very specific to this PR and is not usable across cluster toolkit in general. Introducing this change needs testing to ensure nothing else breaks.

And adding anything to core modules is restricted to the Google team as it comes under our SLA to support. Can you keep your changes to the community/modules. You can add your own docker installation script if needed

I can remove the Docker fix from this PR sure, however I'd have to disagree with your statement that the change is only relevant to this PR. The Docker installation option is used within the startup-script module for example (https://github.com/GoogleCloudPlatform/cluster-toolkit/tree/main/modules/scripts/startup-script).

If you use this module / variable with the documented Rocky HPC image (https://cloud.google.com/cluster-toolkit/docs/tutorials/best-practices) your cluster deployment will fail.

Whilst it is possible to use a custom Docker installation script it isn't a good experience overall having to implement this customisation for each and every Rocky cluster we deploy.

@scott-nag Please take action on this PR, since it is open from very long

Hello, I responded on this PR to mention that the Docker fix is necessary for the VDI functionality.

Please read my response above. Many thanks.

this PR has been inactive for 34 days and has changes requested. @scott-nag, please address the requested changes or close the PR if it's no longer needed.

This is a second reminder that this PR has been inactive for 297 days and has changes requested. @scott-nag, please address the requested changes or close the PR if it's no longer needed.

@scott-nag This PR was automatically closed after being inactive for more than 21 days.